fix(agent-scan): honor provider-configured timeout_ms for HTTP targets - #617
Open
boy-hack wants to merge 1 commit into
Open
fix(agent-scan): honor provider-configured timeout_ms for HTTP targets#617boy-hack wants to merge 1 commit into
boy-hack wants to merge 1 commit into
Conversation
The HTTP provider request path hardcoded the adapter-level default timeout (30s) in httpx.Client(timeout=self.timeout) and never passed the per-provider timeout. Consequently a user-supplied `timeout_ms` (e.g. 300000 in openclaw.yaml) was silently ignored, causing slow agent targets to abort at the 30s default. - Add optional `timeout_seconds` param to `_make_http_request`, falling back to `self.timeout` when unset. - Thread `ProviderConfig.timeout_ms` (via existing `_get_timeout_seconds`) through every HTTP caller: custom HTTP endpoint, standard/template provider, Dify, and Coze. - Report the effective timeout in the timeout error message. Fixes #613. Reproduced locally (request aborted at 30.3s before, now completes at the configured 5-minute timeout).
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx.Client(timeout=self.timeout)and never passed the per-provider timeout, so a user-suppliedtimeout_ms(e.g. 300000 in openclaw.yaml) was silently ignored. Slow agent targets aborted at the 30s default.timeout_secondsparam to_make_http_request(falls back toself.timeout).ProviderConfig.timeout_ms(via existing_get_timeout_seconds) through every HTTP caller: custom HTTP endpoint, standard/template provider, Dify, Coze.Verification
timeout_ms=300000).python3 -m py_compilepasses; no external callers of_make_http_requestexist.Note: merge is left to maintainer discretion per project workflow.